Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename display_parent_relation to display_allocations #168

Open
ewuerger opened this issue Dec 5, 2024 · 1 comment
Open

Rename display_parent_relation to display_allocations #168

ewuerger opened this issue Dec 5, 2024 · 1 comment

Comments

@ewuerger
Copy link
Member

ewuerger commented Dec 5, 2024

Basically the title.

@huyenngn
Copy link
Member

huyenngn commented Dec 9, 2024

Since the display_parent_relation flag defaults to True for all model elements now, consider changing the name to hide_parent_relation/hide_allocations, which defaults to False. Having flags default to True seems counterintuitive, as it might be confusing to explicitly set a flag and not have it change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants