From 48606c1482924eed01db22a0f9cd7b6ad06fca5f Mon Sep 17 00:00:00 2001 From: MoritzWeber Date: Wed, 25 Sep 2024 10:46:02 +0200 Subject: [PATCH 1/2] test: Add delay to let mat-error animation complete The mat-error animation didn't complete for an invalid input of the ManageGitModelComponent. --- .../git/manage-git-model/manage-git-model.stories.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/app/projects/models/model-source/git/manage-git-model/manage-git-model.stories.ts b/frontend/src/app/projects/models/model-source/git/manage-git-model/manage-git-model.stories.ts index 28458b1e6..8c96fd7b3 100644 --- a/frontend/src/app/projects/models/model-source/git/manage-git-model/manage-git-model.stories.ts +++ b/frontend/src/app/projects/models/model-source/git/manage-git-model/manage-git-model.stories.ts @@ -44,7 +44,11 @@ export default meta; type Story = StoryObj; export const InvalidURL: Story = { - args: {}, + parameters: { + screenshot: { + delay: 300, + }, + }, play: async ({ canvasElement }) => { const canvas = within(canvasElement); const absoluteURL = canvas.getByTestId('absolute-url'); From 590740345ba92aaada8fc78f0e3a518bf0b8c565 Mon Sep 17 00:00:00 2001 From: MoritzWeber Date: Wed, 25 Sep 2024 13:04:57 +0200 Subject: [PATCH 2/2] fix: Disable spell checking for API URL --- .../add-git-instance/add-git-instance.component.html | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/frontend/src/app/settings/modelsources/git-settings/add-git-instance/add-git-instance.component.html b/frontend/src/app/settings/modelsources/git-settings/add-git-instance/add-git-instance.component.html index 64f21933a..a7d4697d7 100644 --- a/frontend/src/app/settings/modelsources/git-settings/add-git-instance/add-git-instance.component.html +++ b/frontend/src/app/settings/modelsources/git-settings/add-git-instance/add-git-instance.component.html @@ -39,7 +39,12 @@

Link a Git Server Instance

@if (gitInstancesForm.controls.type.value !== "General") { API Base URL - + @if (gitInstancesForm.controls.url.errors?.urlSchemeError) { API URLs have to start with 'http(s)://' }