Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Verify compatibility of TeamForCapella model links at all times #1791

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Sep 11, 2024

Due to the stricter verification it's no longer possible to update the version of TeamForCapella servers. A version update of the TeamForCapella server would indicate that all linked repositories are migrated to the new Capella version automatically. This is not the usual update process. Instead, models are migrated one by one. This would be realized with the registration of another TeamForCapella server. Repositories are then slowly moved over. When the migration is finished, the old TeamForCapella server can be removed. The only valid use case I'm aware of that would require the modification of the version is that the user selected a wrong version during creation. In this case, the server has to removed and the integration has be created again.

The PR also fixes a bug that t4c models couldn't be moved to another T4C instance.
The submit button of the T4C repository creation is now disabled when a request is running to avoid double-requests.

  • Disable updates of the TeamForCapella server version
  • Only display compatible servers during linking
  • Update backend route to only allow compatible version during linking
  • Verify compatibility when model version is updated
  • Add test for "Verify compatibility when model version is updated"
  • Add tests for T4C repository <> model links

Is the last part of #1739. Resolves #1739.

Copy link

github-actions bot commented Sep 11, 2024

A Storybook preview is available for commit 058e67e.
➡️ View Storybook
➡️ View Chromatic build

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (070c555) to head (55a38d9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ackend/capellacollab/projects/toolmodels/routes.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   83.96%   84.36%   +0.40%     
==========================================
  Files         194      195       +1     
  Lines        6459     6487      +28     
  Branches      714      720       +6     
==========================================
+ Hits         5423     5473      +50     
+ Misses        880      855      -25     
- Partials      156      159       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch 2 times, most recently from c75a139 to d133ed0 Compare September 11, 2024 20:34
@DSD-DBS DSD-DBS deleted a comment from github-actions bot Sep 11, 2024
@MoritzWeber0 MoritzWeber0 marked this pull request as draft September 20, 2024 13:01
@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch from d133ed0 to b72c8e3 Compare September 25, 2024 11:43

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch from b72c8e3 to 4888b2f Compare September 25, 2024 13:20

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch from 4888b2f to e445a0a Compare September 26, 2024 07:30

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch 2 times, most recently from 71b99df to 98212b1 Compare September 26, 2024 16:32
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review September 26, 2024 16:32
@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch from 98212b1 to 26b3646 Compare September 26, 2024 16:33

This comment has been minimized.

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the check-capella-version-for-linked-repos branch from 26b3646 to 55a38d9 Compare September 26, 2024 19:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

This report was generated by comparing 058e67e with 070c555.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 275
change 9
new 18
delete 4
📝 Report

Differences

Helpers_Skeleton Loaders_Form Field_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Helpers_Skeleton Loaders_Form Field_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Git_Invalid URL_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Archived Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Archived Instance_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Existing Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Existing Instance_mobile.png

actual Actual
expected Expected
difference Difference

New Items

Model Components_Model Sources_Create T4C Model_General_desktop.png

NewItem

Model Components_Model Sources_Create T4C Model_General_mobile.png

NewItem

Model Components_Model Sources_Create T4C Model_Instance Selected_desktop.png

NewItem

Model Components_Model Sources_Create T4C Model_Instance Selected_mobile.png

NewItem

Model Components_Model Sources_Create T4C Model_Loading_desktop.png

NewItem

Model Components_Model Sources_Create T4C Model_Loading_mobile.png

NewItem

Model Components_Model Sources_Create T4C Model_No Instances_desktop.png

NewItem

Model Components_Model Sources_Create T4C Model_No Instances_mobile.png

NewItem

Model Components_Model Sources_Update T4C Model_General_desktop.png

NewItem

Model Components_Model Sources_Update T4C Model_General_mobile.png

NewItem

Model Components_Model Sources_Update T4C Model_Loading_desktop.png

NewItem

Model Components_Model Sources_Update T4C Model_Loading_mobile.png

NewItem

Model Components_Model Sources_Update T4C Model_Modify_desktop.png

NewItem

Model Components_Model Sources_Update T4C Model_Modify_mobile.png

NewItem

Model Components_Model Sources_Update T4C Model_No Instances_desktop.png

NewItem

Model Components_Model Sources_Update T4C Model_No Instances_mobile.png

NewItem

Model Components_Model Sources_Update T4C Model_No Repository_desktop.png

NewItem

Model Components_Model Sources_Update T4C Model_No Repository_mobile.png

NewItem

Deleted Items

Model Components_Model Sources_T4C_General_desktop.png

DeleteItem

Model Components_Model Sources_T4C_General_mobile.png

DeleteItem

Model Components_Model Sources_T4C_Loading_desktop.png

DeleteItem

Model Components_Model Sources_T4C_Loading_mobile.png

DeleteItem

@MoritzWeber0 MoritzWeber0 merged commit 8a98406 into main Sep 26, 2024
31 of 32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the check-capella-version-for-linked-repos branch September 26, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Capella T4C instances cannot be removed or renamed
1 participant