-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Verify compatibility of TeamForCapella model links at all times #1791
Conversation
A Storybook preview is available for commit 058e67e. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
+ Coverage 83.96% 84.36% +0.40%
==========================================
Files 194 195 +1
Lines 6459 6487 +28
Branches 714 720 +6
==========================================
+ Hits 5423 5473 +50
+ Misses 880 855 -25
- Partials 156 159 +3 ☔ View full report in Codecov by Sentry. |
c75a139
to
d133ed0
Compare
d133ed0
to
b72c8e3
Compare
This comment has been minimized.
This comment has been minimized.
b72c8e3
to
4888b2f
Compare
This comment has been minimized.
This comment has been minimized.
4888b2f
to
e445a0a
Compare
This comment has been minimized.
This comment has been minimized.
71b99df
to
98212b1
Compare
98212b1
to
26b3646
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
26b3646
to
55a38d9
Compare
|
This report was generated by comparing 058e67e with 070c555. ArtifactName:
|
item | count |
---|---|
pass | 275 |
change | 9 |
new | 18 |
delete | 4 |
📝 Report
Differences
Helpers_Skeleton Loaders_Form Field_Loading_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Helpers_Skeleton Loaders_Form Field_Loading_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Model Components_Model Sources_Git_Invalid URL_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Settings Components_Modelsources_T4C_Server Instance_Archived Instance_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Settings Components_Modelsources_T4C_Server Instance_Archived Instance_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Settings Components_Modelsources_T4C_Server Instance_Existing Instance_desktop.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
Settings Components_Modelsources_T4C_Server Instance_Existing Instance_mobile.png
actual | ![]() |
---|---|
expected | ![]() |
difference | ![]() |
New Items
Model Components_Model Sources_Create T4C Model_General_desktop.png
![]() |
Model Components_Model Sources_Create T4C Model_General_mobile.png
![]() |
Model Components_Model Sources_Create T4C Model_Instance Selected_desktop.png
![]() |
Model Components_Model Sources_Create T4C Model_Instance Selected_mobile.png
![]() |
Model Components_Model Sources_Create T4C Model_Loading_desktop.png
![]() |
Model Components_Model Sources_Create T4C Model_Loading_mobile.png
![]() |
Model Components_Model Sources_Create T4C Model_No Instances_desktop.png
![]() |
Model Components_Model Sources_Create T4C Model_No Instances_mobile.png
![]() |
Model Components_Model Sources_Update T4C Model_General_desktop.png
![]() |
Model Components_Model Sources_Update T4C Model_General_mobile.png
![]() |
Model Components_Model Sources_Update T4C Model_Loading_desktop.png
![]() |
Model Components_Model Sources_Update T4C Model_Loading_mobile.png
![]() |
Model Components_Model Sources_Update T4C Model_Modify_desktop.png
![]() |
Model Components_Model Sources_Update T4C Model_Modify_mobile.png
![]() |
Model Components_Model Sources_Update T4C Model_No Instances_desktop.png
![]() |
Model Components_Model Sources_Update T4C Model_No Instances_mobile.png
![]() |
Model Components_Model Sources_Update T4C Model_No Repository_desktop.png
![]() |
Model Components_Model Sources_Update T4C Model_No Repository_mobile.png
![]() |
Deleted Items
Model Components_Model Sources_T4C_General_desktop.png
![]() |
Model Components_Model Sources_T4C_General_mobile.png
![]() |
Model Components_Model Sources_T4C_Loading_desktop.png
![]() |
Model Components_Model Sources_T4C_Loading_mobile.png
![]() |
Due to the stricter verification it's no longer possible to update the version of TeamForCapella servers. A version update of the TeamForCapella server would indicate that all linked repositories are migrated to the new Capella version automatically. This is not the usual update process. Instead, models are migrated one by one. This would be realized with the registration of another TeamForCapella server. Repositories are then slowly moved over. When the migration is finished, the old TeamForCapella server can be removed. The only valid use case I'm aware of that would require the modification of the version is that the user selected a wrong version during creation. In this case, the server has to removed and the integration has be created again.
The PR also fixes a bug that t4c models couldn't be moved to another T4C instance.
The submit button of the T4C repository creation is now disabled when a request is running to avoid double-requests.
Is the last part of #1739. Resolves #1739.