-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commit history #1100
Comments
@MoritzWeber0, few questions--right now the git_instances table has types for GITHUB, GITLAB, AZUREDEVOPS, and GENERAL.
|
Exactly, "General" means that users can link any supported Git repository, which follow the Git standard and can be used with the Git clients / CLI. Some jobs like T4C -> Git backups and read-only sessions just use the general Git interface and ignore the Git type. You can just throw
Gitlab is most used and also supported better than GitHub, so I'd go for Gitlab first. The iterative approach sounds good (Start with Gitlab, add other Git server types later). |
@MoritzWeber0 -- questions! Linking to author profile: I should be able to link to a commit author's Collab profile if they used the same email for both the Collab Manager and GitLab (and just leave it unlinked with the commit author's name if not), but do we know if that's the norm for our users on production? And if so, do you think it's easier to read commit authors as their username or their actual name? ("nicholasromeo" or "Nicholas Romeo"?) Number of branches and commits: Should we only show the primary git model branch, every git model branch, or every branch that we can see for any given model at the provided URL? For a project with 1 model and a single branch, a user on a laptop could see maybe 8 commits on screen at once. For 2 models or branches that becomes about 3ish commits each. I'm thinking primary git model revision should be open and show at least a few of the most recent commits on page load, while the other models or branches start out collapsed. Does that seem like a good start, or do you have some other specific use case you wanted? Descriptions: Shown from page load, or only with a click-to-expand? (Descriptions not included at all in picture above.) I'm not sure what our users' commits generally look like (just titles? Important info in description?) |
@MoritzWeber0 -- questions! Here, it gets a bit tricky. We don't store the email address of users yet, but we get the information from the OAuth provider and this is something that should store in our database. If we don't find a match, we will not link to a user profile, but still show the commit.
For the beginning, I'd only show the branch linked to the primary Git model of each Collaboration Manager tool model. We should load the commits of all Collaboration Manager models and display them in one timeline (if we have three tool models, merge the commits of the three models in one timeline).
Most commits have no description, some have a small description and some have a large description. I'd say that we only show it with click-to-expand. |
On model level, we should have a commit history. The commit history is fetched from different sources:
For each commit, we should display:
The text was updated successfully, but these errors were encountered: