Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass HTTP request headers to docling when parsing via url #634

Open
lharrison13 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #642
Open

Pass HTTP request headers to docling when parsing via url #634

lharrison13 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #642
Labels
enhancement New feature or request

Comments

@lharrison13
Copy link

Requested feature

Might be out of scope but would it make sense to allow users to pass HTTP request headers to the DocumentParser and cli so we can parse documents on domains behind authentication?

Alternatives

Alternatively users can pull the document themselves then parse it, but I figured it would be nice to have OOTB.
@lharrison13 lharrison13 added the enhancement New feature or request label Dec 19, 2024
@dolfim-ibm
Copy link
Contributor

Actually, we have already the first steps for this feature. The code downloading the files allows for custom headers, see https://github.com/DS4SD/docling-core/blob/main/docling_core/utils/file.py#L52.

We only need to propagate the arguments all the way to the CLI and the main convert functions.

@lharrison13
Copy link
Author

@dolfim-ibm I can try opening a pr to add this if you want. I think since you are the primary contact at IBM for DS4SD I technically need your permission to do so though.

@lharrison13 lharrison13 linked a pull request Dec 21, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added http header support for document converter and cli lharrison13/docling
2 participants
@dolfim-ibm @lharrison13