Move all inline style to dedicated endpoint #2877
Conversation
We rendered the <style> within the <body> which is not valid. By moving it to a dedicated endpoint we also save a bit of bandwith as this is content which stays static during the contest.
| #[Route(path: '/dynamic-css', name: 'get_dynamic_css')] | ||
| public function dynamicCSS(): Response { | ||
| $response = new Response(); | ||
| $response->headers->set('Content-Type', 'text/css'); |
There was a problem hiding this comment.
We should maybe set some expire headers? Otherwise browsers won't cache it.
Drawback is that it will change once the colors change, so maybe use an etag header instead?
There was a problem hiding this comment.
We discussed and I'll try to implement a cache and keep the etag there.
| @@ -100,6 +100,14 @@ public function scoreboardDataZipAction( | |||
| return $this->dj->getScoreboardZip($request, $requestStack, $contest, $this->scoreboardService); | |||
| } | |||
|
|
|||
| #[Route(path: '/dynamic-css', name: 'get_dynamic_css')] | |||
There was a problem hiding this comment.
The name is too broad. It should be something like scoreboardCategoryColorCss or something.
There was a problem hiding this comment.
And rename if there are more?
There was a problem hiding this comment.
More dynamic CSS? I would put them in separate actions, since otherwise you get one big if here, which doesn't make sense IMHO.
There was a problem hiding this comment.
I'll change it for now, not sure if we have more pages like this so if the discussion will actually ever be non-theoretical.
We rendered the <style> within the which is not valid. By moving it to a dedicated endpoint we also save a bit of bandwith as this is content which stays static during the contest.