Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration is unsuitable for single core machines #136

Open
david-perez opened this issue Oct 2, 2022 · 1 comment
Open

Configuration is unsuitable for single core machines #136

david-perez opened this issue Oct 2, 2022 · 1 comment

Comments

@david-perez
Copy link

judgedaemon.conf contains:

So supervisor goes ahead and starts 2 judgehosts, domjudge-contributor-0 and domjudge-contributor-1.

This configuration is unsuitable for running domjudge in single core machines. In a single core machine, if a judging is routed to domjudge-contributor-1, the daemon id 1 is eventually sent to rungard.c in the cpuset option. runguard.c performs a check to ensure cpuset >= 0 && cpuset < nproc, and crashes the judgehost with Running compile.sh caused an error/crash: /domjudge/bin/runguard: processor ID 1 given as cpuset, but only 1 cores configured.

Subsequent judgings will succeed since the judgehost gets disabled, but I was thoroughly confused.

I'm unfamiliar with how supervisor works, but ideally numprocs would be templated in from somewhere that caps it to the actual number of cores on the host.

@nickygerritsen
Copy link
Member

We should make this an option with default 2 that you can override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants