Add PHPStan & Fix existing errors (no backwards-compatibility breaks) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdingemanse
approved these changes
Mar 10, 2021
BackEndTea
reviewed
Mar 10, 2021
| @@ -29,10 +29,12 @@ class FolderManager extends AbstractManager implements FolderManagerInterface, L | |||
| * | |||
| * @param int $page | |||
| * @param int $perPage | |||
| * @param array $filters | |||
There was a problem hiding this comment.
According to the interface it should be array|null
There was a problem hiding this comment.
No right? Because you cannot literally pass null?
There was a problem hiding this comment.
It has a default value, but not a type on the method itself.
So if you ignore the docblock you can pass in literally anything 😉
BackEndTea
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added PHPStan to this project with a config on
level 0(very lenient).I have also updated the README with instructions on how to use this.
While running level 0, I found two issues:
src/Managers/FolderManager.phpdid not adhere to its interface.illuminate/paginationis a dependency that was not included in the package.Both of these issues have also been fixed. I have checked the implementation that is used for
illuminate/paginationand I have added all version constraints that are compatible with the implementation.