Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve optimize images workflow #466

Open
1 of 3 tasks
martvanrijthoven opened this issue Aug 16, 2022 · 0 comments
Open
1 of 3 tasks

improve optimize images workflow #466

martvanrijthoven opened this issue Aug 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@martvanrijthoven
Copy link
Contributor

martvanrijthoven commented Aug 16, 2022

failed job: https://github.com/DIAGNijmegen/website-content/actions/runs/2865886921
previous succeeded job: https://github.com/DIAGNijmegen/website-content/actions/runs/2780797879

The failed job did not have a cache:

Run actions/cache@v2
Cache not found for input keys: Linux-node-64052880d0bdd2703b442d6a8f45cd00cd411a122739d39f746bdb7c2a9f7de5, Linux-node-

While in the previous succeeded job, it used a cache. I think somewhere, something has been updated which failed the job.
netlifly-client is not installed with a specific version, though installing an older version did not work: https://github.com/DIAGNijmegen/website-content/actions/runs/2866123267. However, it might be that even an older version was used in the cache.

I have now upgraded netlify-client, node, and sharp library which solved the problem.

Furthermore, this workflow crashed to concurrent remote changes. A manual rerun solves this issue for now.

TODO

  • add status badge for optimize images
  • backtrack netlify-client version and check if we want to set a specific version
  • check how we can prevent workflow crashes due to concurrent changes (check build deploy workflow)
@martvanrijthoven martvanrijthoven added the bug Something isn't working label Aug 16, 2022
@martvanrijthoven martvanrijthoven self-assigned this Aug 16, 2022
@martvanrijthoven martvanrijthoven added enhancement New feature or request and removed bug Something isn't working labels Aug 17, 2022
@martvanrijthoven martvanrijthoven changed the title investigate why image optimization failed and how to prevent it in the future improve optimize images workflow Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant