Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Replace theme.js to theme.ts #8

Open
4 tasks
bertearazvan opened this issue Sep 7, 2020 · 0 comments
Open
4 tasks

Replace theme.js to theme.ts #8

bertearazvan opened this issue Sep 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bertearazvan
Copy link
Contributor

bertearazvan commented Sep 7, 2020

As our boilerplate is based on Typescript, we should make sure that all of the files that we bootstrap are based on Typescript.

One of the files that are currently not using Typescript is theme.js. While trying to migrate this file to using .ts we have encountered the following problems in regards to the types:

  • Not using custom palette keys such as "medium". We should focus only on the given options.
  • Using themeName throws errors as it is not part of the Theme type. I believe this is because themeName might be deprecated after some materialUI version (import { Theme } from ".../core"; - for the Theme types/interface.
  • The overrides contains MaterialUI pickers classes which are not included in the general materialUI classes. I believe the best way to deal with this is either remove it and to keep only materialUI classes and eventually keep a log of the pickers classes. Or maybe add the pickers/types as peerDependencies?
  • There are some errors with the '&hover' events.
@bertearazvan bertearazvan added the bug Something isn't working label Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant