Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Operations] New operation requests from User Study #115

Open
1 of 5 tasks
qiaw99 opened this issue Jun 26, 2023 · 3 comments
Open
1 of 5 tasks

[Operations] New operation requests from User Study #115

qiaw99 opened this issue Jun 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@qiaw99
Copy link
Collaborator

qiaw99 commented Jun 26, 2023

@qiaw99 qiaw99 added the enhancement New feature or request label Jun 26, 2023
@qiaw99 qiaw99 added this to the Camera-ready version milestone Jun 26, 2023
@nfelnlp nfelnlp changed the title [Operations] New operations during User Study [Operations] New operation requests from User Study Jun 26, 2023
@nfelnlp
Copy link
Member

nfelnlp commented Jun 30, 2023

@qiaw99
Copy link
Collaborator Author

qiaw99 commented Jul 27, 2023

@nfelnlp For now, I cann't really imagine a solution that would be able to implement include + similar. The reason is as follows:

  1. include relies on temp_dataset.
  2. When you call similar operation, e.g. show me the most similar one compared to instance 15. The corresponding parsed text is: filter 15 and similar 1. After doing this, the temp_dataset is already changed, containing only one instance which is id 15.
  3. As a result, the previous filtered temp_dataset by include operation will be "removed".

@qiaw99
Copy link
Collaborator Author

qiaw99 commented Jul 27, 2023

In other words, in order to run any include related operations, user couldn't call any operations related to id (filter id and xxx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants