Remove parity check service and ECF integration points #2026
+0
−4,936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-2026-web.test.teacherservices.cloud/ |
ethax-ross
force-pushed
the
3791-remove-parity-check
branch
from
dc9930c
to
bb97ac8
Compare
Remove parity check service, remaining ECF models and views. Revert rack_attack to be enabled in migration. Remove gems used for parity check. Remove ECF schema and databse connection.
ethax-ross
force-pushed
the
3791-remove-parity-check
branch
from
bb97ac8
to
b1b8de9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-3791
Context
We have separated NPQ from ECF and no longer need to run parity checks; so we want to remove all of the parity check-related code.
Changes proposed in this pull request
Remove parity check service, remaining ECF models and views.
Revert rack_attack to be enabled in migration.
Remove gems used for parity check.
Remove ECF schema and databse connection.
Guidance for review
Once this has been merged down we can remove the following secrets from keyvault: