[CPDNPQ-2142] Add validation when marking Statement as paid #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebw
force-pushed
the
2142-freeze-statements
branch
from
3d2ea86
to
9c7cb1b
Compare
jebw
force-pushed
the
2142-tighten-validations-for-entering-paid-state
branch
from
c6937bc
to
476d424
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: CPDNPQ-2142
We want to ensure that a statement has been recorded as having been paid at the point it transitions to a Paid state
Changes proposed in this pull request
marked_as_paid_atfield is presentFailed feature specs screenshots
If any of the feature specs would fail, there will be page on the wiki with all
failures:
https://github.com/DFE-Digital/npq-registration/wiki/