From 582fe3e174420878a90e975cf7b87df91ff46a32 Mon Sep 17 00:00:00 2001
From: Richard Lynch <rjlynchdev@gmail.com>
Date: Mon, 16 Dec 2024 14:12:23 +0000
Subject: [PATCH] Return duplicate ids

Return the duplicate claim ids from the query and introduce a struct to
wrap the result. This change will make it easier to reuse this query if
trying to find duplicates of a specific claim.
---
 .../reports/duplicate_approved_claims.rb      | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/app/models/admin/reports/duplicate_approved_claims.rb b/app/models/admin/reports/duplicate_approved_claims.rb
index 8a8df5434..7b5f81d98 100644
--- a/app/models/admin/reports/duplicate_approved_claims.rb
+++ b/app/models/admin/reports/duplicate_approved_claims.rb
@@ -32,6 +32,8 @@ def to_csv
 
       private
 
+      class DuplicateClaimRow < Struct.new(:id, :other_claim_id, keyword_init: true); end
+
       attr_reader :academic_year
 
       def rows
@@ -39,9 +41,12 @@ def rows
       end
 
       def scope
-        Claim.where(
-          id: Set.new(duplicates_by_eligibility + duplicates_by_attributes)
-        ).includes(decisions: :created_by)
+        Claim.where(id: Set.new(duplicates.map(&:id)))
+          .includes(decisions: :created_by)
+      end
+
+      def duplicates
+        duplicates_by_eligibility + duplicates_by_attributes
       end
 
       def duplicates_by_eligibility
@@ -49,7 +54,7 @@ def duplicates_by_eligibility
           Policies::POLICIES.map do |policy|
             policy_with_claimable_policies(policy)
           end.compact.join("\nUNION\n")
-        ).map { |row| row["id"] }
+        ).map(&DuplicateClaimRow.method(:new))
       end
 
       def policy_with_claimable_policies(policy)
@@ -70,7 +75,7 @@ def policy_with_claimable_policies(policy)
           )
 
           <<~SQL
-            SELECT claims.id
+            SELECT claims.id, other_claims.id AS other_claim_id
             FROM #{left_table}
             JOIN #{right_table} #{right_table_alias}
             ON #{left_table}.id != #{right_table_alias}.id
@@ -173,7 +178,7 @@ def duplicates_by_attributes
           end.join(" AND ")
 
           <<~SQL
-            SELECT current_claims.id
+            SELECT current_claims.id, other_claims.id AS other_claim_id
             FROM current_claims
             JOIN current_claims other_claims
             ON #{join_condition}
@@ -183,7 +188,7 @@ def duplicates_by_attributes
 
         query = current_claims + "\n" + filter
 
-        ActiveRecord::Base.connection.execute(query).map { |row| row["id"] }
+        ActiveRecord::Base.connection.execute(query).map(&DuplicateClaimRow.method(:new))
       end
 
       class ClaimPresenter