Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add compartment postfix to metabolite identifiers #95

Open
kvikshaug opened this issue Jun 21, 2019 · 2 comments
Open

Don't add compartment postfix to metabolite identifiers #95

kvikshaug opened this issue Jun 21, 2019 · 2 comments

Comments

@kvikshaug
Copy link
Member

Currently, we add a compartment postfix to any metabolite id from added reactions. That was relevant when adding reactions from BiGG, but now that we're adding any reaction from metanetx, this logic should be removed. That would allow us to remove for example this and this piece of logic.

@Midnighter
Copy link
Contributor

You mean any non-native metabolite? Because metabolites from added reactions might be mapped to native metabolites that are then in BiGG notation and need to have the compartment suffix?

@kvikshaug
Copy link
Member Author

Yes, indeed. We'd still use the postfix when looking for native metabolites (it would be nice to confirm that the model is in BiGG namespace before doing that though).

In effect, the changes I'm thinking of with this issue is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants