[RFC] The use of pnpm

[dcyoung-dev]

Problem

Onboarding new developers can be complicated, do we need the additional step of installing and using pnpm?

Current setup

1. Install NodeJS
2. Install pnpm globally in Node - using npm
3. Use pnpm to install dependancies and run dev environment

Proposal

Remove pnpm from the development stack.

Onboarding steps

1. Install NodeJS
   Install pnpm globally in Node - using npm
2. Use npm to install dependancies and run dev environment

Reasoning

To install pnpm requires npm which comes as part of the NodeJS installation by default.
Having less tooling and less dependencies is usually a good thing.

We have CI tasks that do not use pnpm and require updating to use it.

As npm is pre-packaged in Node it is surely the default for most developers.

Cons

pnpm claims to be 2x faster than npm. This probably only matters at a very large scale

Removing pnpm will require updates to our documentation. Mostly removals of steps

Notes

npm and pnpm are both package managers within the Node ecosystem. Both provide the same functionality.

[dexslab]

As of node v16.13 like yarn pnpm is included with node there is one additional step to enable it.

corepack enable

That is all and pnpm is working without additional issues.
Also look at it like this as well there is a comparison on npm vs pnpm.

All CI has already been converted to use pnpm

pnpm vs npm

[dcyoung-dev]

I may have missed the point 👌

We have a few Github actions that don't use it

• EX-WebThrottle2/.github/workflows/deploy.yml

  Line 45 in 298f2d8

  - name: Install dependencies

• EX-WebThrottle2/.github/workflows/eslint.yml

  Line 46 in 298f2d8

  run: npx eslint .

Do these need updating?

[dexslab]

Yes those do i thought i got everything but i missed those its a quick process to fix it though