Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited Allowance #6

Open
rashtrakoff opened this issue May 22, 2022 · 0 comments
Open

Unlimited Allowance #6

rashtrakoff opened this issue May 22, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rashtrakoff
Copy link
Member

For upgrading ERC20 tokens to supertokens, we require providing allowance to the supertoken contract. This is done in individual strategy contracts. However, there is a chance that we might hit uint256 max amount (very unlikely but possible).

Suggest to check for allowance and also check if the top up is possible with the current allowance to the supertoken contract. If not, approve the contract once again.

The code for the same should ideally be in StrollManager.sol. However, to not break existing deployments, it's recommended to not change it from strategy contracts. However for the next version, see to it that it's moved. This will also help us with gas savings.

@rashtrakoff rashtrakoff self-assigned this May 22, 2022
@rashtrakoff rashtrakoff added the enhancement New feature or request label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant