Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation step before the manual release #49

Open
csala opened this issue May 20, 2020 · 2 comments
Open

Add confirmation step before the manual release #49

csala opened this issue May 20, 2020 · 2 comments

Comments

@csala
Copy link
Contributor

csala commented May 20, 2020

In the Orion project we have introduced a confirmation step before pushing the new release to PyPI in the manual workflow to prevent releases from being made accidentally if PyPI credentials are configured in the user's .pypirc.

https://github.com/signals-dev/Orion/blob/584d7dc5dc247cfb615768b0cd473b9f664c1e3b/Makefile#L152

Now the release prompt looks like this:

$ make release
... merge to stable, bumpversion and dist happens here ...
WARNING: This will irreversibly upload a new version to PyPI!
Please type 'confirm' to proceed: confirm    <- confirm is typed by the user
... The new version files are uploaded to PyPI, also asking for username and password if .pypirc is not configured ...

May we add this to the cookiecutter template?

@csala
Copy link
Contributor Author

csala commented May 20, 2020

@micahjsmith ?

@micahjsmith
Copy link
Contributor

fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants