Localization update #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 26, 2019 14:37
- Update iOS Deployment Target to iOS 8 (Minimum supported by Xcode 10). - Apply recommended settings for the `DMPasscode` & `Pods` project. - Enable `Base Internationalization`. - Migrate “English.lproj” (Deprecated). - Remove `:exclusive => true` from `Podfile`, as it is an unsupported option. - Add `platform :ios, ‘8.0’` to `Podfile` to resolve CocoaPods warning. - Update `podspec` to version `2.1.0`. - Run `pod install` from `Example` directory.
- Add `self ->` in a number of places to resolve warnings.
Nomad00
commented
Aug 26, 2019
| @@ -90,7 +86,8 @@ - (void)showPasscodeInViewController:(UIViewController *)viewController completi | |||
| _completion = completion; | |||
| LAContext* context = [[LAContext alloc] init]; | |||
| if ([context canEvaluatePolicy:LAPolicyDeviceOwnerAuthenticationWithBiometrics error:nil]) { | |||
| [context evaluatePolicy:LAPolicyDeviceOwnerAuthenticationWithBiometrics localizedReason:NSLocalizedString(@"dmpasscode_touchid_reason", nil) reply:^(BOOL success, NSError* error) { | |||
| NSBundle *bundle = [NSBundle bundleWithPath:[[NSBundle bundleForClass: [DMPasscode class]] pathForResource:@"DMPasscode" ofType:@"bundle"]]; | |||
There was a problem hiding this comment.
I'm not of fan of getting the NSBundle this way, however when I attempted to get it the more clear(?) way, (NSBundle *bundle = [NSBundle bundleForClass: [DMPasscode class]];), the localized string lookup did not work.
This approach was found over on Medium.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed when using
DMPasscodeon a device with Face ID configured, thekeywas being returned from the customNSLocalizedStringmacro (instead of the localized string). This was causing aNon-empty localizedReason must be providederror to be thrown. The remedy for this is found in the 3rd commit below; the first 2 clean things up.localization-update - Project settings modernization.
DMPasscode&Podsproject.Base Internationalization.:exclusive => truefromPodfile, as it is an unsupported option.platform :ios, ‘8.0’toPodfileto resolve CocoaPods warning.podspecto version2.1.0.pod installfromExampledirectory.localization-update -
Implicit selfwarning resolutions.self ->in a number of places to resolve warnings.localization-update - Resolve
NSLocalizedStringmacro collision.NSLocalizedStringmacro, as it was causing issues when leveraged from Swift code.NSLocalizedStringFromTableInBundledirectly.NSFaceIDUsageDescriptionto example appInfo.plist.