Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2pool status shows green even after Node is killed #57

Open
sceniclife opened this issue Dec 26, 2024 · 1 comment · May be fixed by #59
Open

P2pool status shows green even after Node is killed #57

sceniclife opened this issue Dec 26, 2024 · 1 comment · May be fixed by #59
Labels
bug Something isn't working

Comments

@sceniclife
Copy link

sceniclife commented Dec 26, 2024

OS & Version:

Windows 10, Gupaxx v1.6.0

Bug

P2pool status shows green 'ok' status after Node is killed

Steps

Steps to reproduce the behavior:

  1. Start Node
  2. Start P2pool
  3. Wait for both to show green 'ok' status
  4. Kill Node
  5. P2pool will report ZMQ communication error but will stay green status.

Additional Info

If P2pool is started first and Node is never started or connected, P2pool status shows orange state. I would expect this be the state that P2pool reports if Node was killed while running.

@sceniclife sceniclife added the bug Something isn't working label Dec 26, 2024
@Cyrix126
Copy link
Owner

Cyrix126 commented Dec 27, 2024

Gupaxx could watch the console output of p2pool to know when to set state to orange instead green. But if the user set the log level to 0, it would not work since there would be no error messages. log level 1 would be the minimum required.
Gupaxx can't watch the status of Node for that since P2Pool could connect to a non local Node. Also to know if the connection is restored after a failure, P2Pool would need to be set to log level 2.

The first solution would be to force the minimum log level to 2 or to get the status from the API, which for now does not include it. I don't know C++, so I can't make a PR for it.
SChernykh/p2pool#328

@Cyrix126 Cyrix126 linked a pull request Dec 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants