Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Node status to find already running Monerod #54

Open
sceniclife opened this issue Dec 20, 2024 · 2 comments
Open

Request for Node status to find already running Monerod #54

sceniclife opened this issue Dec 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@sceniclife
Copy link

sceniclife commented Dec 20, 2024

Feature request
The Node tab only shows status if monerod is started from Gupaxx.
If I have Monero GUI Wallet running with it's monerod already running, Gupaxx does not detect it.

But if I start Node process in Gupaxx, then open Monero GUI Wallet, it automatically detects and connects to the monerod from Gupaxx.

It would be nice for Gupaxx to behave the same?

Additional context
If you start monerod, the settings in Gupaxx do not auto populate the fields in Monero GUI Wallet (expected).
So I wouldn't expect those settings in Monero GUI Wallet to auto populate in Gupaxx if monerod was started in Monero GUI Wallet.
I would probably just blur/disable the input fields in the Node tab (similar when something is entered in Command arguments with a tooltip stating that monerod running externally or something.

If monerod was started in Gupaxx, Monero GUI Wallet asks the user if they would like to keep the local node running or force stop when closing the Monero GUI Wallet.

@Cyrix126 Cyrix126 added the enhancement New feature or request label Dec 23, 2024
@Cyrix126 Cyrix126 mentioned this issue Dec 23, 2024
34 tasks
@Cyrix126
Copy link
Owner

The issue is, Gupaxx has no way to know if the node was started with the right settings for p2pool and if the options were ok to get the stats.

Gupaxx could expect the right settings and be in a failure state (red) in the case it can't interact properly with it, showing a descriptive warning of arguments to start monerod with to make it work.

@sceniclife
Copy link
Author

I see. I understand.

For p2pool, it should behave as if connecting to a remote node and is unaware of what settings were done. For Gupaxx, for reporting status of the externally running node, I believe the monerod commands give most of that information? Unless there is something I don't see, you would know best. :)

For Monero GUI Wallet, it doesn't matter the binary path for where monerod was started. In Gupaxx Advanced settings, I tried setting the binary path to the monerod of Monero GUI Wallet and also the included bundle node binary path (Node\monerod.exe). Monero GUI Wallet will show the correct status, syncronized and height.

But yes, I agree with the suggested assumption that the node was started correctly and try using it. Error status if it does not work. This would be the simplest integration.

Thanks for adding to road map!

...
If it is a must to get the settings information for node, other solutions with way more work and their own complications:

  1. Update monerod commands and add a print_daemon_flags
  2. It's possible to find the stored values for daemonFlags of the Monero GUI Wallet.
    (on my Windows machine: HKEY_CURRENT_USER\SOFTWARE\monero-project\monero-core)
    There is also a wallet_path value if you wanted to cross reference with the set path in Gupaxx.

Issue with (2) is that, there's no guarantee that those settings belong to the node that is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants