Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEI Compat Error Log Causes Massive Client Lag #141

Closed
N1ghthauq opened this issue Nov 27, 2024 · 2 comments
Closed

JEI Compat Error Log Causes Massive Client Lag #141

N1ghthauq opened this issue Nov 27, 2024 · 2 comments

Comments

@N1ghthauq
Copy link

Issue type:

  • 🐛 Bug

Short description:

When looking at anvil recipes while in an integrated terminals terminal. The JEI spends an insane amount of tick time writing error logs.

I don't have logs for other recipes yet, but I do know that this issue impacts more than anvil recipes.

Steps to reproduce the problem:

  1. Open a terminal. (I have a really large network that may be compounding the issues)
  2. Find an anvil recipe to look at in JEI. I used a tool and looked at what enchants can be applied.
  3. Observe lag. It can cause the game to freeze and become unresponsive, or soft crash.

Expected behaviour:

Check anvil recipes, and other recipes without the client lag.


Versions:

  • This mod: 1.6.5
  • Minecraft: 1.21.1
  • Mod loader version: neoforge 21.1.80

I haven't tested this without the other mods, and I am using the latest ATM 10.
I am posting here first due to the logs pointing at the integrated terminals/jei compatibility errors.
This issue has been present for a long time, ~ATM 8 is when I first noticed this.

Log file:

Spark Profiler Client Side
https://imgur.com/a/RjlEUnf
Integrated Lag.zip

Error Log:
https://pastebin.com/tDxQ2SBX

If you want the full log, I will have to upload another zip file. It is too large to put in pastebin.

@rubensworks
Copy link
Member

Thanks for reporting!

@Jack-McKalling
Copy link
Contributor

This issue may already be on the radar, as mentioned here: #139 (comment)

But I'm not exactly sure, so until that issue's fix has been finalized, I'll leave this open just in case it turns out to be a separate bug.

@github-project-automation github-project-automation bot moved this from To Do to Done in Maintenance Nov 27, 2024
rubensworks added a commit that referenced this issue Nov 27, 2024
Fixes:
* Fix JEI lag caused by non-crafting recipes being considered in terminal
  Closes #141
* Fix JEI/EMI/REI cache not invalidating when player inv changes
* Improve JEI/REI/EMI performance, #139
rubensworks added a commit to CyclopsMC/IntegratedTerminals-Compat that referenced this issue Nov 27, 2024
rubensworks added a commit to CyclopsMC/IntegratedTerminals-Compat that referenced this issue Nov 27, 2024
rubensworks added a commit that referenced this issue Nov 27, 2024
Fixes:
* Fix JEI lag caused by non-crafting recipes being considered in terminal
  Closes #141
* Fix JEI/EMI/REI cache not invalidating when player inv changes
* Improve JEI/REI/EMI performance, #139
rubensworks added a commit that referenced this issue Nov 27, 2024
Fixes:
* Fix JEI lag caused by non-crafting recipes being considered in terminal
  Closes #141
* Fix JEI/EMI/REI cache not invalidating when player inv changes
* Improve JEI/REI/EMI performance, #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants