Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grash when inserting script card in wrong exporter slot #20

Closed
Hiranus opened this issue Oct 27, 2024 · 6 comments
Closed

Grash when inserting script card in wrong exporter slot #20

Hiranus opened this issue Oct 27, 2024 · 6 comments

Comments

@Hiranus
Copy link

Hiranus commented Oct 27, 2024

Issue type:

  • 🐛 Bug

Short description:

Game crashes when I insert a card that executes this function into wrong slot in any exporter

function anvils() { return [ itemByName("minecraft:damaged_anvil"), itemByName("minecraft:chipped_anvil"), itemByName("minecraft:anvil"), ]; }

Steps to reproduce the problem:

  1. make card that executes script provided above,
  2. insert it into single item slot or predicate exporter

Expected behaviour:

Red X instead of crash.


Versions:

  • This mod: 1.0.6
  • Minecraft: 1.21.1
  • Mod loader version: NeoForge 21.1.72

Log file:

https://pastebin.com/KnvwzJdH

@rubensworks
Copy link
Member

Thanks for reporting!

@rubensworks
Copy link
Member

I haven't been able to reproduce the problem you're describing.
This should have been fixed as of #9
Are you sure you're using the latest version of all ID mods?
If yes, could you share a video or more details steps to reproduce the problem?

@rubensworks rubensworks moved this from To Do to On hold (awaiting input) in Maintenance Oct 28, 2024
@Hiranus
Copy link
Author

Hiranus commented Oct 28, 2024

https://streamable.com/ifbmeg

latest.log

You can also reach out to me on your Discord. I'm Hiran there.

Streamable
Watch "unknown_2024.10.28-17.25" on Streamable.

@rubensworks
Copy link
Member

Ah, it's the world item exporter. I thought it was the regular item exporter.

@rubensworks rubensworks moved this from On hold (awaiting input) to To Do in Maintenance Oct 28, 2024
@rubensworks
Copy link
Member

@Hiranus From your video, it also appears you are using an applied function (using apply3).
Could you describe the steps that were necessary to create this variable?

@rubensworks rubensworks moved this from To Do to On hold (awaiting input) in Maintenance Oct 28, 2024
@Hiranus
Copy link
Author

Hiranus commented Oct 28, 2024

script0.txt

This is the script I'm using.

You can pick any function with 3 arguments. Here are some descriptions of parameters
itemsInChamber - list of items from entitiesToItemIds(entities) where "entities" is just a list of items on the floor read by entity reader
itemsToDisenchant - list of items from inventory reader
isChamberDisenchanting - boolean, you can just pass false during your testing
shouldImport*Realized - just functions with same name after running apply on them.

If you want to understand the goal of this script, here is a brief description:
Apotheosis adds disenchanting of items by dropping anvil on obsidian block that has enchanted items and books on it. Goal of this whole contraption is to automate this process. I'm checking if there are any items to disenchant and if there is anything being disenchanted. If nothing is being processed, then I drop stack of books and few items and drop anvil on it.

@rubensworks rubensworks moved this from On hold (awaiting input) to To Do in Maintenance Oct 29, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in Maintenance Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants