[1.21.1-Neo] Instant disconnect upon trying to join server. (org.cyclops.cyclopscore.helper.RecipeSerializerHelpers.writeItemStackOrItemStackIngredientChance(RecipeSerializerHelpers)

[Gbergz]

Issue type:

• 🐛 Bug

---

Short description:

Instant disconnect when joining server all of a sudden. Logs point to CyclopsCore so I'll report here see what comes of it.

Steps to reproduce the problem:

1. Attempt to join server.
2. Instant disconnect.

Expected behaviour:

That server is joinable without disconnect.

---

Versions:

• This mod: 1.23.0-601
• Minecraft: 1.21.1
• Mod loader version: NeoForge 21.1.54

Log file:

https://gist.githubusercontent.com/Gbergz/1e59c6e65ace4b9b30c973c1085602c5/raw/de3dd3f649ef53a9d46c205d6581f76a325f1dfa/gistfile1.txt

EDIT:

After some digging I found out that removing Integrated Dynamics causes this issue to disappear. And re-adding it makes issue appear again. So something around Integrated Dynamics.

Versions for integrated mods:
IntegratedDynamics v1.23.5
IntegratedCrafting v1.1.10
IntegratedTerminals v1.5.2
IntegratedTunnels v1.8.28

[rubensworks]

Thanks for reporting!

[rubensworks]

Note to self: use ItemStack codecs that accept empty in read and write: https://github.com/CyclopsMC/CyclopsCore/blob/master-1.21/loader-neoforge/src/main/java/org/cyclops/cyclopscore/recipe/ItemStackFromIngredient.java#L79-L100

Just weird that this hasn't happened before. Probably indicates broken/custom recipes in a modpack.

GitHub

CyclopsCore/loader-neoforge/src/main/java/org/cyclops/cyclopscore/recipe/ItemStackFromIngredient.java at master-1.21 · CyclopsMC/CyclopsCore

Minecraft library mod for EvilCraft, Integrated Dynamics and others. - CyclopsMC/CyclopsCore

[rubensworks]

I'll push a fix which should fix your problem, but there's a small chance it may not (since I wasn't able to reproduce the problem).
Once you've updated to the new version, and the problem should still occur for you, please let me know.

[Gbergz]

Tried just now and unfortunately the issue persists on v1.23.6.
Here's the servers latest.log again:
File: latest.log
Or link: https://gist.githubusercontent.com/Gbergz/4aeecfe6f16992d7456ffb8ed9e95d82/raw/91b3f51b59b87307f4304eb04aec66529b6b2afb/gistfile1.txt

[rubensworks]

Can you reproduce the problem without any other mods installed? I'm suspecting some other mod in your pack may be breaking vanilla ingredient seralization.

[Gbergz]

No I can't so I suspect this is another mod causing issues with Integrated Dynamics/Cyclops Core.. hmm annoying.. :s
Not sure how to find out which other than removing mods one by one until it works, but that's gonna take a long time with so many mods.

[rubensworks]

You could try binary search, which should be a lot faster than removing one-by-one: iteratively removing half of the mods until you find the offending one.

[Gbergz]

Yep, was going to do that and I have done it now.

Removing Occultism makes the issue go away and world is now joinable again. Re-adding it makes issue reappear.

[Gbergz]

After further testings, readding Occultism and removing KubeJS also solves it, so it might be something there.
Edit: Re-adding KubeJS and then deleting the KubeJS folder with the scripts also solves it, so might be something with my scripts currently.

Just weird that this started recently.

[Gbergz]

Found the issue, it was a KubeJS item ban script I have that is breaking stuff together with Cyclops Core + Integrated Dynamics I guess..

Removing it fixes this issue.

[rubensworks]

Glad to hear you found the problem!

[Gbergz]

Thanks for the help on the way, appreciated. :)