remove getters & setters

[jkowalleck]

PROPOSAL: remove getters and setters, if a property can be made type safe and converted to public.

PRO

• less methods to maintain

CON

• no setters = cannot use chained setters ala $instance->setA(1)->setB(2);

code changes

from

class C {
  /** @var bool */
  private $prop = true;

  /** @return $this */
  public function setProp(bool $prop): self
  {
     $this->prop = $prop;
     return $this;
  }
}

to

class C {
  public bool $prop = true;
}

as of #6

[jkowalleck]

as of #6 (comment)

removing setters wouod remove the feature to of chaining, which comes in handy in downstream implementations.