Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change Component.Evidence.Identity to array #204

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: change Component.Evidence.Identity to array #204

wants to merge 10 commits into from

Conversation

DmitriyLewen
Copy link

Description

in CycloneDX 1.6 type of Component.Evidence.Identity has been changed to []Identity.
Identity as struct was marked as deprecated.
https://cyclonedx.org/docs/1.6/json/#tab-pane_metadata_component_evidence_identity_oneOf_i0

Related issues

@DmitriyLewen DmitriyLewen force-pushed the fix/componentEvidence-as-array branch from 9331e90 to 76dd76b Compare October 25, 2024 11:21
@DmitriyLewen
fix: add json tag for Identity
80fede1 
Signed-off-by: DmitriyLewen <[email protected]>
@DmitriyLewen
refactor: update convert package
0170729 
Signed-off-by: DmitriyLewen <[email protected]>
@DmitriyLewen
refactor
31d9544 
Signed-off-by: DmitriyLewen <[email protected]>
DmitriyLewen
DmitriyLewen commented Oct 28, 2024
View reviewed changes
convert.go Show resolved Hide resolved
cyclonedx_xml_test.go Outdated Show resolved Hide resolved
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 28, 2024 06:06
@DmitriyLewen DmitriyLewen requested a review from a team as a code owner October 28, 2024 06:06
This was referenced Oct 28, 2024
Open
Closed
@nscuro nscuro added the bug Something isn't working label Dec 10, 2024
@nscuro
Copy link
Member

nscuro commented Dec 10, 2024

Hmmm, seems like CI never ran for his PR and I can't manually trigger it. @DmitriyLewen do you mind re-opening this PR, or alternatively amend your last commit so GitHub triggers a build?

@DmitriyLewen
Copy link
Author

Hi @nscuro
I reran actions (I merged master branch), but this action still doesn't run despite having your approval - https://github.com/CycloneDX/cyclonedx-go/actions/runs/12270387292
Do you have ideas?

@nscuro
Copy link
Member

nscuro commented Dec 11, 2024

@DmitriyLewen I had to approve CI to run since this is your first PR for this repo. However, I wasn't given that option before you pushed a new commit, which is odd.

Now we have a few test failures.

@DmitriyLewen
Copy link
Author

DmitriyLewen commented Dec 12, 2024 •
edited
Loading

Hello @nscuro
Thanks!

I fixed TestEvidence_MarshalJSON/WithIdentify in 24e9503

About TestRoundTripJSON/valid-evidence.json:
I forgot to update valid-evidence.json and updated this file in d68a199.
But this test is still fail (because schema for identity has been changed).
What can i do with this test?

BTW tests didn't start again :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve support for the Component.Evidence.Identity field in CycloneDX 1.6
2 participants
@DmitriyLewen @nscuro