Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a module-level variable override for the version string #1461

Open
tirazel opened this issue Nov 12, 2024 · 1 comment · May be fixed by #1502
Open

Add a module-level variable override for the version string #1461

tirazel opened this issue Nov 12, 2024 · 1 comment · May be fixed by #1502
Assignees
Labels
change Modification to code without a functional change

Comments

@tirazel
Copy link
Contributor

tirazel commented Nov 12, 2024

We currently have a version string we store in a variable, which is supposed to indicate which version of the codebase is in use on a site. However, this is currently just a string set separately as part of the update process, so if a codebase update failed, but the version string update succeeded, the string then incorrectly states that the codebase has been updated.

Ideally, the version string is done as a variable override in the theme module, so the correct value is returned based on the actual codebase. Currently, the config variable being manually set is 'web_express_version' in the boulder_base.settings config object.

The documentation for adding variable overrides lives here: https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-override-system

@timurtripp timurtripp self-assigned this Nov 12, 2024
@timurtripp
Copy link
Member

IIRC this is initially how I wanted to do it, with the GitHub action modifying the version string in the actual codebase. @jcsparks do you remember why we decided against it?

@timurtripp timurtripp added the new New feature or request label Nov 13, 2024
@timurtripp timurtripp added change Modification to code without a functional change and removed new New feature or request labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Modification to code without a functional change
Projects
None yet
2 participants