Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKGLPlus Hopelessly broken #6

Open
lordofscripts opened this issue Oct 15, 2020 · 0 comments
Open

SKGLPlus Hopelessly broken #6

lordofscripts opened this issue Oct 15, 2020 · 0 comments

Comments

@lordofscripts
Copy link

I suppose the code is a mess (many classes in one file) because it was transported from CodePlex, but it would have looked much better if separated.

However, I tried it and it is hopelessly broken (The SKGLPlus), I had Generate throw an exception because one method was getting the license key with dashes and it crapped out because it did not expect dashes. Validating the same code given by Generated also says it is an invalid license, that is expired and all that was not true.

Additionally, the scheme is weak too, there is no such thing as an 8-byte hash, a hash is cryptographic algorithm and of all those listed in security sites, none has 8 bytes. There are checksums that are around that size though. Also, the code that attempts to generate such a "hash" is more like security by obscurity than anything else.

More examples or tests would have been nice, but then again, it is broken :( so I don't know why it is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant