Default new ds project 188559300 #650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server/tests/admin/test_datasets.py#L232)
gergness
force-pushed
the
default-new-ds-project-188559300
branch
from
4acff60 to
cac70e7
Compare
gergness
changed the base branch from
master
to
non-derived-expr-vars-188532827
gergness
changed the base branch from
non-derived-expr-vars-188532827
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #648 so I don't get too many conflicts (
but this PR is currently based on that, so that it's clear what to review).Users' personal projects are being removed, so need to change where we refer to datasets:
Remaining tech debt
listDatasets()defaults to showing datasets in the personal project. I think leaving this as tech debt is okay, because really thecd(projects(), "/path")is a better way to show datasets thanlistDatasets().