Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[187316938]: comment out tests affected by reusable subvar codes #638

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

gergness
Copy link
Contributor

@gergness gergness commented Mar 26, 2024

For now all tests are commented, but maybe we should just delete them?

Tests fall into broadly 3 categories:

  • tests/testthat/test-append-debug.R tests that appending 2 datasets with array variables with different aliases, but identically aliased sub variables fails. I think @aminusfu is saying that the new intentional behavior is to allow this because variables can belong to multiple arrays now.
  • tests/testthat/test-append-subvariables.R tests that appending 2 datasets, one with an array, and the other with unbound versions of the array's sub variables. It expects after appending for the unbound version of the variables to be only included in the arrays. However, now appends will allow 2 versions of the same subvariables to exist.
  • tests/testthat/test-derive-debug.R tests various things about changing the metadata of variables that are the source of derived array subvariables and making sure that the changes get to the derived version. These tests fail because they expect that the subvariable's alias will change when they are derived, so could be fixed by being flexible about the alias. However, it sounds like Mike was in favor of deleting tests that are covered elsewhere, and this seems like what he was thinking of.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (799df38) to head (c26ad44).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         128      128           
  Lines        8503     8503           
=======================================
  Hits         7730     7730           
  Misses        773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crunchbot crunchbot merged commit 20f23a8 into master Mar 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants