[187316938]: comment out tests affected by reusable subvar codes #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now all tests are commented, but maybe we should just delete them?
Tests fall into broadly 3 categories:
tests/testthat/test-append-debug.R
tests that appending 2 datasets with array variables with different aliases, but identically aliased sub variables fails. I think @aminusfu is saying that the new intentional behavior is to allow this because variables can belong to multiple arrays now.tests/testthat/test-append-subvariables.R
tests that appending 2 datasets, one with an array, and the other with unbound versions of the array's sub variables. It expects after appending for the unbound version of the variables to be only included in the arrays. However, now appends will allow 2 versions of the same subvariables to exist.tests/testthat/test-derive-debug.R
tests various things about changing the metadata of variables that are the source of derived array subvariables and making sure that the changes get to the derived version. These tests fail because they expect that the subvariable's alias will change when they are derived, so could be fixed by being flexible about the alias. However, it sounds like Mike was in favor of deleting tests that are covered elsewhere, and this seems like what he was thinking of.