Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run only #566

Merged
merged 11 commits into from
May 18, 2021
Merged

Dry run only #566

merged 11 commits into from
May 18, 2021

Conversation

gergness
Copy link
Contributor

@gergness gergness commented Apr 20, 2021

Pull out the dry run part out of #555 so we can merge it without the multi-file support

And add handling of async validation errors and encoding specification

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #566 (3c0b1d4) into master (f828924) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 3c0b1d4 differs from pull request most recent head ca45c6f. Consider uploading reports for the commit ca45c6f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   90.59%   90.62%   +0.02%     
==========================================
  Files         128      128              
  Lines        8167     8179      +12     
==========================================
+ Hits         7399     7412      +13     
+ Misses        768      767       -1     
Impacted Files Coverage Δ
R/api.R 93.02% <100.00%> (+0.16%) ⬆️
R/automation.R 94.04% <100.00%> (+1.83%) ⬆️
R/progress.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f828924...ca45c6f. Read the comment docs.

handleAPIresponse <- function(
response,
special.statuses = list(),
progress.handler = NULL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

R/api.R Outdated Show resolved Hide resolved
R/automation.R Outdated Show resolved Hide resolved
@gergness gergness merged commit 695f2ba into master May 18, 2021
@gergness gergness deleted the dry-run-only branch May 18, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants