Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script dryrun #555

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Script dryrun #555

wants to merge 5 commits into from

Conversation

gergness
Copy link
Contributor

  • Allows ... in runCrunchAutomatio() so we can use the dry argument (and later dry_run when the API is updated)
  • Allows passing multiple scripts, which are then concatenated. I think this is particularly important for dry runs because the validation would need to be cumulative.
  • I couldn't resist subtracting out the line numbers for multiple scripts, we can undo it if you really want, but I don't think it's that hard to avoid the off by 1 error, and being able to jump right to errors in their original file when running runCrunchAutomation(list.files(), dry_run = TRUE) is a huge UX improvement.

Screen Shot 2021-03-23 at 4 18 23 PM

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #555 (542d9e4) into master (bda1b53) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

❗ Current head 542d9e4 differs from pull request most recent head 20f18f0. Consider uploading reports for the commit 20f18f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.01%     
==========================================
  Files         128      128              
  Lines        8032     8052      +20     
==========================================
+ Hits         7269     7287      +18     
- Misses        763      765       +2     
Impacted Files Coverage Δ
R/automation.R 91.75% <90.90%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda1b53...20f18f0. Read the comment docs.

@gergness
Copy link
Contributor Author

gergness commented Apr 5, 2021

On hold while crunch automation changes how multi-file support works

@gergness gergness mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant