GT 2465 create extension for lesson flow views #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaelblue
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks @levieggertcru, looks great! That cleaned things up much better. I was struggling piecing it together (and not knowing where else to get some of those attributes).
levieggertcru
deleted the
GT-2465-create-extension-for-lesson-flow-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rachaelblue I went ahead and made some updates to the LessonFlow and added a getLesson() method to allocate the LessonView. I noticed it helps clean up the Flows by creating individual methods for allocating the Views. The renderer will also get allocated at that point. I think that helped clean things up a bit more.
Let me know if the init logic looks right.
I also created a reference to the ToolTranslationsDomainModel and also added a computed property for the lesson: ResourceModel on the LessonFlow. Some of those properties I don't think you were fully aware of which is understandable.
Also removed some files marked for iOS 14 obsolete. Nice to have those removed for iOS 15.