Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2196 Pass the filter language when opening a spotlight tool #3273

Merged
merged 37 commits into from
Jan 10, 2024

Conversation

frett
Copy link
Contributor

@frett frett commented Dec 13, 2023

This converts the entire Tools UI to use Circuit

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 260 lines in your changes are missing coverage. Please review.

Comparison is base (abdbf99) 31.92% compared to head (efe6d27) 33.63%.

Files Patch % Lines
...otlin/org/cru/godtools/ui/tools/ToolCardLayouts.kt 20.27% 98 Missing and 16 partials ⚠️
...org/cru/godtools/ui/dashboard/tools/ToolsLayout.kt 23.07% 28 Missing and 2 partials ⚠️
.../cru/godtools/ui/dashboard/tools/ToolsPresenter.kt 71.69% 18 Missing and 12 partials ⚠️
...n/org/cru/godtools/ui/dashboard/DashboardLayout.kt 21.42% 22 Missing ⚠️
...org/cru/godtools/ui/dashboard/DashboardActivity.kt 7.14% 10 Missing and 3 partials ⚠️
...n/org/cru/godtools/ui/dashboard/home/HomeLayout.kt 0.00% 11 Missing ⚠️
...kotlin/org/cru/godtools/ui/tools/ToolViewModels.kt 0.00% 10 Missing ⚠️
...org/cru/godtools/ui/dashboard/tools/ToolFilters.kt 65.38% 4 Missing and 5 partials ⚠️
...lin/org/cru/godtools/ui/tools/ToolCardPresenter.kt 87.50% 1 Missing and 5 partials ⚠️
...del/src/main/kotlin/org/cru/godtools/model/Tool.kt 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3273      +/-   ##
===========================================
+ Coverage    31.92%   33.63%   +1.71%     
===========================================
  Files          439      443       +4     
  Lines        10784    11029     +245     
  Branches      2408     2482      +74     
===========================================
+ Hits          3443     3710     +267     
+ Misses        6801     6717      -84     
- Partials       540      602      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch 3 times, most recently from 1269aaa to 43ec0de Compare December 14, 2023 20:03
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch from ac69e44 to 5d51f67 Compare December 15, 2023 00:53
@frett frett marked this pull request as draft December 15, 2023 15:50
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch 8 times, most recently from 1024597 to 12610b8 Compare December 22, 2023 19:49
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch from 12610b8 to 0de12fb Compare December 23, 2023 01:33
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch from 0de12fb to 55f9115 Compare January 2, 2024 20:54
@frett frett added the has tests label Jan 3, 2024
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch from dcd4daa to ef6325f Compare January 3, 2024 17:57
@frett frett removed the needs tests label Jan 3, 2024
@frett frett marked this pull request as ready for review January 3, 2024 21:27
@frett frett requested a review from gyasistory January 3, 2024 21:27
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch 3 times, most recently from 3fee86c to 5a95b3f Compare January 5, 2024 18:02
frett added 27 commits January 8, 2024 11:45
@frett frett force-pushed the GT-2196-spotlight-tool-additional-language branch from 3a2fea4 to efe6d27 Compare January 8, 2024 18:46
@frett frett merged commit b7442ee into develop Jan 10, 2024
12 checks passed
@frett frett deleted the GT-2196-spotlight-tool-additional-language branch January 10, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants