Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2166 GT-2167 app language fixes #3181

Merged
merged 16 commits into from
Oct 23, 2023
Merged

GT-2166 GT-2167 app language fixes #3181

merged 16 commits into from
Oct 23, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #3181 (d7ebb7e) into develop (98f5691) will increase coverage by 0.06%.
The diff coverage is 26.78%.

@@             Coverage Diff             @@
##           develop    #3181      +/-   ##
===========================================
+ Coverage    32.70%   32.76%   +0.06%     
===========================================
  Files          426      428       +2     
  Lines        10507    10515       +8     
  Branches      2303     2302       -1     
===========================================
+ Hits          3436     3445       +9     
+ Misses        6514     6513       -1     
  Partials       557      557              
Files Coverage Δ
.../cru/godtools/ui/dashboard/tools/ToolsViewModel.kt 80.48% <100.00%> (ø)
...ges/downloadable/DownloadableLanguagesViewModel.kt 95.23% <100.00%> (-0.42%) ⬇️
...n/kotlin/org/cru/godtools/base/util/LocaleUtils.kt 81.81% <ø> (+6.81%) ⬆️
...t/ui/settings/SettingsBottomSheetDialogFragment.kt 0.00% <ø> (ø)
...ru/godtools/ui/languages/LanguageSettingsLayout.kt 0.00% <0.00%> (ø)
...tlin/org/cru/godtools/tutorial/TutorialActivity.kt 0.00% <0.00%> (ø)
...org/cru/godtools/tutorial/layout/TutorialLayout.kt 0.00% <0.00%> (ø)
...n/org/cru/godtools/ui/tools/AvailableInLanguage.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/org/cru/godtools/base/Settings.kt 47.27% <60.00%> (+0.72%) ⬆️
...ings/SettingsBottomSheetDialogFragmentDataModel.kt 0.00% <0.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett force-pushed the appLanguageFixes branch 2 times, most recently from ac15731 to bb25a2a Compare October 20, 2023 15:13
@frett frett changed the title GT-2166 fix app language support for older versions of Android GT-2166 app language fixes Oct 20, 2023
@frett frett changed the title GT-2166 app language fixes GT-2166 GT-2167 app language fixes Oct 20, 2023
frett added 15 commits October 20, 2023 15:45
also localize the context object for older versions of Android, without this context.getString() doesn't reflect the currently configured app language
this works around older versions of Android not correctly updating Locale.getDefault()
@frett frett merged commit de1dc63 into develop Oct 23, 2023
12 checks passed
@frett frett deleted the appLanguageFixes branch October 23, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants