-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT-2166 GT-2167 app language fixes #3181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3181 +/- ##
===========================================
+ Coverage 32.70% 32.76% +0.06%
===========================================
Files 426 428 +2
Lines 10507 10515 +8
Branches 2303 2302 -1
===========================================
+ Hits 3436 3445 +9
+ Misses 6514 6513 -1
Partials 557 557
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
frett
force-pushed
the
appLanguageFixes
branch
2 times, most recently
from
October 20, 2023 15:13
ac15731
to
bb25a2a
Compare
frett
changed the title
GT-2166 fix app language support for older versions of Android
GT-2166 app language fixes
Oct 20, 2023
also localize the context object for older versions of Android, without this context.getString() doesn't reflect the currently configured app language
this works around older versions of Android not correctly updating Locale.getDefault()
…e instead of deviceLocale
frett
force-pushed
the
appLanguageFixes
branch
from
October 20, 2023 19:47
6415dc1
to
e70388d
Compare
frett
force-pushed
the
appLanguageFixes
branch
from
October 20, 2023 19:55
e70388d
to
d7ebb7e
Compare
gyasistory
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.