Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2153 try refreshing the google id_token if it is rejected #3129

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #3129 (6cf3d96) into develop (97d9019) will increase coverage by 0.03%.
The diff coverage is 46.15%.

@@             Coverage Diff             @@
##           develop    #3129      +/-   ##
===========================================
+ Coverage    32.16%   32.20%   +0.03%     
===========================================
  Files          426      426              
  Lines        10492    10499       +7     
  Branches      2326     2327       +1     
===========================================
+ Hits          3375     3381       +6     
+ Misses        6557     6553       -4     
- Partials       560      565       +5     
Files Coverage Δ
...s/account/provider/google/GoogleAccountProvider.kt 51.72% <46.15%> (+15.36%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett changed the title GT-2153 try refreshing google tokens if they have expired:wq GT-2153 try refreshing google tokens if they have expired Oct 2, 2023
@frett frett requested a review from gyasistory October 2, 2023 22:32
@frett frett marked this pull request as draft October 4, 2023 17:05
@frett frett removed the request for review from gyasistory October 4, 2023 17:05
@frett frett force-pushed the googleAuthRefresh branch 3 times, most recently from eb5a32e to f87c8be Compare October 4, 2023 17:54
@frett frett force-pushed the googleAuthRefresh branch from f87c8be to 6cf3d96 Compare October 5, 2023 20:42
@frett frett requested a review from gyasistory October 5, 2023 20:43
@frett frett added the has tests label Oct 5, 2023
@frett frett changed the title GT-2153 try refreshing google tokens if they have expired GT-2153 try refreshing the google id_token if it is rejected Oct 5, 2023
@frett frett marked this pull request as ready for review October 5, 2023 20:44
@frett frett merged commit 6a3887d into develop Oct 6, 2023
12 checks passed
@frett frett deleted the googleAuthRefresh branch October 6, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants