Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morse code for non-Latin alphabets #61

Open
Rult opened this issue Mar 30, 2021 · 9 comments
Open

Morse code for non-Latin alphabets #61

Rult opened this issue Mar 30, 2021 · 9 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@Rult
Copy link

Rult commented Mar 30, 2021

https://en.wikipedia.org/wiki/Russian_Morse_code#Table_&_Melody

@CrazyMarvin
Copy link
Contributor

Hey, that is a great idea. 👍
Would you be up to open a PR for it?

@Rult
Copy link
Author

Rult commented Mar 30, 2021

Yeah, I think I can add the cyrillic letters by myself.

@Rult Rult changed the title Russian morse code support Russian morse code encoding support Mar 30, 2021
@CrazyMarvin CrazyMarvin added the enhancement New feature or request label Mar 30, 2021
@CrazyMarvin
Copy link
Contributor

Wonderful, thank you so much for your input! 👍

@Rult
Copy link
Author

Rult commented Mar 30, 2021

In a future, it may be useful to implement some language switch on decoding -- https://en.wikipedia.org/wiki/Morse_code_for_non-Latin_alphabets?stable=1

But I don't really think Morse code is that popular to play with outside the CIS countries.

@CrazyMarvin CrazyMarvin changed the title Russian morse code encoding support Morse code for non-Latin alphabets Apr 2, 2021
@CrazyMarvin
Copy link
Contributor

That is a great idea. I will keep this issue open. PRs and comments are welcome.
Where would you put the switch, @Rult? Maybe in the Settings or directly on the first screen? 🤔

@CrazyMarvin CrazyMarvin reopened this Apr 2, 2021
@Rult
Copy link
Author

Rult commented Apr 2, 2021

Maybe place it to the right of the Phrasebook button?
Otherwise, the app can just detect non-English system language and directly ask the user to switch it in the settings.

@Rult
Copy link
Author

Rult commented Apr 2, 2021

Or maybe better this way:

4

@CrazyMarvin
Copy link
Contributor

The mockup was just updated to include this proposal.

@CrazyMarvin
Copy link
Contributor

What do you think about the updated mockup, @Rult?
Do you have time to create a PR this month?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants