Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode #155

Open
swifty-tim opened this issue Dec 17, 2019 · 1 comment
Open

Support dark mode #155

swifty-tim opened this issue Dec 17, 2019 · 1 comment

Comments

@swifty-tim
Copy link

swifty-tim commented Dec 17, 2019

Expected Behavior

When showing Rating and Feedback widget, it would be nice to have dark mode support.

Current Behavior

It current just has a background color of white.

Screenshots (if appropriate):

Not really required.

Possible Solution

As the feedback view is a web view, you could load a CSS file with dark mode supported.

Steps to Reproduce (for bugs)

  1. Show the widget

More Description

I don't think any is required.

Your Environment

iOS 13.3
Xcode 11.3
Countly 19.08

  • Countly iOS SDK version
  • Your iOS version
  • Any changes you have made to this SDK
@erkanyildiz
Copy link
Member

Hi @collegboi

Nice idea. While requesting feedback widget, we can send a special flag to indicate user's dark mode preference, so server can return a modified CSS, special for dark mode.

Let me discuss this with my teammates, as this requires both design and server side work.
Another approach would be just overriding CSS on the app side, but I do not think it is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants