-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bindings for the pinned metrics #526
Conversation
This PR also adds a Nix flake. I can remove it again if it's not wanted in-tree, I just used it to set up a Go development environment quickly. Installing everything manually would have taken me longer, so a few lines of Nix and a |
3fb2576
to
d562f89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Just the encoding question and some minor ideas here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's wait for a 2.1 pre-release tag before we merge this
The 2.1.0-rc.1 is released now and merged on main, so this can be updated to that. |
505bf39
to
cfd0f16
Compare
@chipshort Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I just don't recall anymore what the reason behind the comment was
Co-authored-by: Simon Warta <[email protected]>
Okay, I finally figured it out. I really don't know Go well enough.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just wondering about the flake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add Go FFI bindings for the new pinned metrics. Uses MessagePack as the encoding format for complex types across the boundary.
Follow-up to CosmWasm/cosmwasm#2034
(This is me whipping out my rusty (haha, funny pun) Go skills from around (if not before) Go 1.11)
TODO: