Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration doesnt implement Eq trait #7

Open
MbBrainz opened this issue Jan 9, 2023 · 2 comments
Open

Duration doesnt implement Eq trait #7

MbBrainz opened this issue Jan 9, 2023 · 2 comments

Comments

@MbBrainz
Copy link

MbBrainz commented Jan 9, 2023

I guess this would be nice to have. Is there a reason for not implementing it?

@maurolacy
Copy link
Contributor

Probably nobody needed it so far. Go ahead and submit a PR if you want.

@webmaster128
Copy link
Member

Through #[cw_serde] it derives PartialEq. But because of that we don't see a clippy warning to also add Eq. Feel free to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants