Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Cache-Busting Query Parameters to Webpack Output Files #445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khanti42
Copy link
Collaborator

PR Description

This PR introduces cache-busting query parameters to Webpack’s filename and chunkFilename configurations. This change ensures that both entry point files and dynamically imported chunks avoid issues caused by DNS or browser caching, particularly in production environments. The addition of query parameters (?v=[fullhash]) helps load the latest versions of assets, even if stale files are cached.

@khanti42 khanti42 requested a review from a team as a code owner November 28, 2024 09:01
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team November 28, 2024 09:01
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants