Reenable TX Outcome Checks for Replay Tests #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
1521-reenable-tx-outcome-checks
branch
from
369e51b
to
2c464e2
Compare
fab-10
reviewed
Nov 26, 2024
This updates the block capture debugging facility. This allows one to generate captures from running tests locally. The updates simply improve the generated capture filenames.
This renames the replay test files so that they all indicate whether or not they are mainnet or sepolia blocks.
This renames replay files which represent a single block to avoid the hyphonated notation. For example, `123-123.json.gz` is renamed to `123.json.gz`
This updates the record TX outcomes in the replay test files to correctly follow mainnet. This was done by playing the replays back through the ReplayExecutionEnvironment and the recording the outcomes using the BlockCapturer.
The `BesuPlugin` interface has changed slightly, with `BesuContext` being deprecated in favour of `ServiceManager`. This simply updates the various plugins used by the linea tracer to this new API. Most of the changes were straightforward.
DavePearce
force-pushed
the
1521-reenable-tx-outcome-checks
branch
from
2c464e2
to
900b74f
Compare
gauravahuja
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the record TX outcomes in the replay test files to correctly follow mainnet. This was done by playing the replays back through the ReplayExecutionEnvironment and the recording the outcomes using the BlockCapturer.
NOTE: this also updates linea-besu to 660a354 (as this includes the finalised fix for traceEndTransaction()).