From 6bb1e8a7022c13d8c688c7fa851c0dc2ca0e46e7 Mon Sep 17 00:00:00 2001 From: DavePearce Date: Fri, 29 Nov 2024 10:41:33 +1300 Subject: [PATCH] Fixes for GeneralStateTests This puts through two minor fixes for the GeneralStateTests. Firstly, it adds notifications from the Rust corset side. Secondly, it drops parallelism from the go-corset side. --- .github/workflows/gradle-ethereum-tests.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gradle-ethereum-tests.yml b/.github/workflows/gradle-ethereum-tests.yml index 72690e777..c32e94ab2 100644 --- a/.github/workflows/gradle-ethereum-tests.yml +++ b/.github/workflows/gradle-ethereum-tests.yml @@ -51,6 +51,15 @@ jobs: reference-tests/build/reports/tests/**/* tmp/local/* + - name: Failure Notification + if: ${{ failure() || cancelled() }} + uses: slackapi/slack-github-action@v2.0.0 + with: + webhook: ${{ secrets.SLACK_WEBHOOK_URL }} + webhook-type: webhook-trigger + payload: | + name: "Daily Reference Tests (Rust Corset)" + status: "${{ job.status }}" ethereum-tests-go-corset: runs-on: ubuntu-latest-128 @@ -73,7 +82,7 @@ jobs: run: cd ./linea-constraints; make zkevm_for_reference_tests.bin -B; cd .. - name: Generate General State Reference Tests - run: ./gradlew generateGeneralStateReferenceTests -Dorg.gradle.parallel=true -Dorg.gradle.caching=true + run: ./gradlew generateGeneralStateReferenceTests -Dorg.gradle.caching=true env: JAVA_OPTS: -Dorg.gradle.daemon=false CORSET_FLAGS: fields,expand,expand,expand @@ -101,5 +110,5 @@ jobs: webhook: ${{ secrets.SLACK_WEBHOOK_URL }} webhook-type: webhook-trigger payload: | - name: "Daily Reference Tests" + name: "Daily Reference Tests (Go Corset)" status: "${{ job.status }}"