-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: strict ModReduce in emulated fields #1224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting to draft until bugs fixed. |
gbotrel
requested changes
Jul 24, 2024
2 tasks
Fixes pushed. |
gbotrel
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1147, but more thoroughly. Added separate method which performs modular reduction and asserts that the result is in range. Updated the documentation accordingly.
Additionally, added an option to algebra methods to obtain the canonical bit representation if necessary (when comparing bitwise some values).
The current implementation are not modified - if the prover would provide
x+p
from the hint, then the recursion implementations fail to solve as we have incorrect FS challenges.We now have reduction in the 2-chain PLONK verifier as previously when performing binary decomposition of BLS12 points we used canonical decomposition, but now by default we don't.
Type of change
How has this been tested?
How has this been benchmarked?
Checklist:
golangci-lint
does not output errors locally