Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shared Royalty Token contracts #89

Open
5 of 6 tasks
barlock opened this issue Feb 11, 2019 · 0 comments
Open
5 of 6 tasks

Implement Shared Royalty Token contracts #89

barlock opened this issue Feb 11, 2019 · 0 comments
Labels

Comments

@barlock
Copy link
Contributor

barlock commented Feb 11, 2019

Overview

As a developer building a PIB token, I'd like a reference implementation, interfaces, and abstract classes so that I can quickly iterate on my dApp PIB token implementation.

Reference

Questions

  • HMW scale a Shared Royalty Token and allow for virtually unlimited franchisors?
    • Gas prices on transfer will likely increase drastically on transfer function if math is in there preventing sale after a certain number
  • How do we handle withdraw?
    • Is there an ERC standard for handling this allowing for rounding error?
    • Likely there is something to do with the first question here. 🤷‍♂️
  • Is 721 the correct abstraction?

Assumptions

Acceptance

  • Shared Royalty Token
    • A Shared Royalty Token interface ISharedRoyaltyToken
    • An abstract contract SRT AbstractSharedRoyaltyToken.
      • Contains common SRT implmentations
  • SharedRoyaltyTokenEnumerable enumerable
    • Interface ISharedRoyaltyTokenEnumerable
    • Implemented SharedRoyaltyTokenEnumerable for extending
  • PIBBookendToken
    • Implements abstract class and transferPayoutByFranchisorIndex to match bookend model

Story Draft

  • Create withdrawal SharedRoyaltyToken interface (likely just find an existing ERC or other art)
  • Implement ISharedRoyaltyToken (pib interface)
  • Implement ISharedRoyaltyTokenEnumerable (Enumerable interface)
  • Implement AbstractSharedRoyaltyToken
  • Implement SharedRoyaltyTokenEnumerable
  • Implement SharedRoyaltyBookendToken
@barlock barlock transferred this issue from another repository Feb 11, 2019
@barlock barlock added the Epic label Feb 11, 2019
@barlock barlock changed the title Implement PIBToken contracts Implement Shared Royalty Token contracts Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant