Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-constant gas costs for token minting #5

Open
GNSPS opened this issue May 24, 2017 · 1 comment
Open

Non-constant gas costs for token minting #5

GNSPS opened this issue May 24, 2017 · 1 comment

Comments

@GNSPS
Copy link
Contributor

GNSPS commented May 24, 2017

https://github.com/ConsenSys/curationmarkets/blob/master/CurationMarkets.sol#L71

Implements a correct yet very expensive system for token minting that linearly increases in execution price with the token amount being bought.

I propose modeling this along the lines of what Bancor has done with their continuous price function.
(v. https://github.com/bancorprotocol/contracts/blob/master/solidity/contracts/BancorFormula.sol)
(v. https://drive.google.com/file/d/0B3HPNP-GDn7aRkVaV3dkVl9NS2M/view)

@simondlr
Copy link
Contributor

Yeah. I suspected there's a way to improve it, but I couldn't math well enough to fit it into a specific function. Will definitely take a look at the Bancor Formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants