T1903 Fix /children/random redirect producing 404 error (#52)

* Fix 404 for child with state='I'

* Fix pre-commit issue

crowdfunding_compassion/models/crowdfunding_participant.py

@@ -68,7 +68,6 @@ class CrowdfundingParticipant(models.Model):
         "and to this partner.",
     )
 
-
     # kanban colors
     color_sponsorship = fields.Char(compute="_compute_color_sponsorship")
     color_product = fields.Char(compute="_compute_color_product")

website_sponsorship/controllers/main.py

@@ -91,6 +91,19 @@ def load_child(self, **kwargs):
         # Put a child on hold and display its page
         return request.render("website_sponsorship.load_child_page")
 
+    def _ensure_child_available(self, child) -> None:
+        """Checks if child is in an available state and displays a NotFound page
+        otherwise.
+
+        Args:
+            child (CompassionChild): The child to check for availability.
+
+        Raises:
+            NotFound: Raised if child is not available.
+        """
+        if child.state not in child._available_states():
+            raise NotFound()
+
     @http.route(
         [
             # [T1835] : Note: the route MUST be specified *without* a trailing
@@ -110,8 +123,7 @@ def load_child(self, **kwargs):
         sitemap=False,
     )
     def child_page(self, child, show_sponsorship_form=False, **kwargs):
-        if child.state != "N":
-            raise NotFound()
+        self._ensure_child_available(child)
         return request.render(
             "website_sponsorship.child_page_template",
             {
@@ -133,8 +145,7 @@ def child_page(self, child, show_sponsorship_form=False, **kwargs):
         sitemap=False,
     )
     def child_sponsor_form(self, child, **kwargs):
-        if child.state != "N":
-            raise NotFound()
+        self._ensure_child_available(child)
         reservation_uuid = self._get_reservation_uuid()
         if not child.sudo().reserve_for_web_sponsorship(reservation_uuid):
             raise Gone()