Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferManager.exists() methods should maintain (and use) the NotFoundCache. #152

Open
jdcasey opened this issue Dec 9, 2016 · 5 comments
Assignees

Comments

@jdcasey
Copy link
Member

jdcasey commented Dec 9, 2016

We need a test that verifies that the NFC isn't affected by current TransferManager.exists() method implementations, then we need to fix them so they do use it. If the NFC contains a missing-path entry for something we're about to check existence for, we should short-circuit and return false. If we do check existence, and it comes up false, we should add it to the NotFoundCache.

@jdcasey
Copy link
Member Author

jdcasey commented Dec 9, 2016

@ruhan1 I assigned this to you since you are probably more familiar with that section of code than anyone else. If you don't have time for it, assign it to me and I'll make sure it's on our radar in the new year. Thanks!

@ruhan1
Copy link
Contributor

ruhan1 commented Dec 9, 2016 via email

@bxf12315
Copy link
Collaborator

retest this please

2 similar comments
@bxf12315
Copy link
Collaborator

retest this please

@bxf12315
Copy link
Collaborator

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants