Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Text Component for Internationalization #148

Open
cristidrg opened this issue Dec 10, 2018 · 0 comments
Open

Create Text Component for Internationalization #148

cristidrg opened this issue Dec 10, 2018 · 0 comments
Labels

Comments

@cristidrg
Copy link
Collaborator

REQUIREMENTS

DATA

  • locale: used to look up in the strings hashmap -- this comes from the redux store
  • stringId: used to look up the string based on the locale -- this comes as a prop

FEATURES

  • Given a stringId and a locale, look up in the strings.js file the correct output and return the text inside a This way we can let the parent of this component say in what element should the text leave (h1/p/span/etc). -- Return value is open for discussion

ACCEPTANCE CRITERIA
Component needs to have propTypes and defaultProps
All the requirements are addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant