Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing menu when scrolling up #116

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: fixing menu when scrolling up #116

wants to merge 2 commits into from

Conversation

adipginting
Copy link
Contributor

This is the intended behavior that I have fixed.

  1. On a large view port.
    image
  2. On a smaller view port.
    image
  3. On a smaller view port and the menu being expanded.
    image

@adipginting adipginting requested review from dastrong and Xazin April 25, 2023 13:14
@vercel
Copy link

vercel bot commented Apr 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 10:19am

@CollActionOfficial CollActionOfficial linked an issue May 9, 2023 that may be closed by this pull request
Menu bar should appear when scrolling up #83
Open
@CollActionOfficial
Copy link
Contributor

Nice work adi! However, It's good that the menu bar disappears when you scroll down. It should only 'scroll in' from the top when you scroll up. You see what I mean?

2 similar comments
@CollActionOfficial
Copy link
Contributor

Nice work adi! However, It's good that the menu bar disappears when you scroll down. It should only 'scroll in' from the top when you scroll up. You see what I mean?

@CollActionOfficial
Copy link
Contributor

Nice work adi! However, It's good that the menu bar disappears when you scroll down. It should only 'scroll in' from the top when you scroll up. You see what I mean?

@adipginting adipginting marked this pull request as draft July 5, 2023 11:53
@adipginting adipginting marked this pull request as ready for review July 13, 2023 10:21
@adipginting
Copy link
Contributor Author

Hello, I have done some modification on the navigation bar with useEffect hook. Kindly check the code or the deployed code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dastrong dastrong Awaiting requested review from dastrong

@Xazin Xazin Awaiting requested review from Xazin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu bar should appear when scrolling up
2 participants
@adipginting @CollActionOfficial